Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support trailing commas everywhere #287

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

lgaborini
Copy link
Contributor

Hello!
Super quick PR that should fix #282 in most layers.

Tested so far:

  • geom_*
  • scale_*
  • facet_*
  • annotate_*
  • label_*
  • element_*
  • guide_*
  • call to girafe()
  • call to girafe_options()

I'm getting this warning in the tests but it seems unrelated:

Warning message:
In vp$just : partial match of 'just' to 'justification'

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.04%. Comparing base (550fe25) to head (5b96a99).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files         106      106           
  Lines        2704     2704           
=======================================
  Hits         2543     2543           
  Misses        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidgohel
Copy link
Owner

Thank you @lgaborini, much appriciated

@davidgohel davidgohel merged commit 0120933 into davidgohel:master Feb 27, 2024
9 checks passed
@lgaborini lgaborini deleted the trailing-comma branch February 27, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could geom_*_interactive support trailing comma's?
3 participants