Fixed: False positive hidden iframe detection when HTML element is zero height #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjbradshaw
commented
Aug 20, 2024
davidjbradshaw
force-pushed
the
fix_detect_hidden
branch
from
f954eaa
to
e095733
Compare
davidjbradshaw
force-pushed
the
fix_detect_hidden
branch
from
e095733
to
89e7f20
Compare
|
Fixed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where the HTML element is somehow zero height. This was causing a false positive on the detecting that the iframe was hidden.
#1309 #1311