Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: jQuery wrapper startup #1317

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix: jQuery wrapper startup #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,8 @@ export default (options) => (iframe) => {
}

if (iframeId === '' || !iframeId) {
// eslint-disable-next-line no-multi-assign
iframe.id = iframeId = newId()
iframeId = newId()
iframe.id = iframeId
setLogEnabled((options || {}).log)
log(iframeId, `Added missing iframe ID: ${iframeId} (${iframe.src})`)
}
Expand Down
3 changes: 2 additions & 1 deletion packages/jquery/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ switch (true) {
default:
window.jQuery.fn.iframeResize = function (options) {
const connectWithOptions = connectResizer(options)
const init = (i, el) => connectWithOptions(el)

return this.filter('iframe').each(connectWithOptions).end()
return this.filter('iframe').each(init).end()
}

window.jQuery.fn.iFrameResize = function (options) {
Expand Down
10 changes: 10 additions & 0 deletions spec/initJQuerySpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@ define(['iframeResizerJquery', 'jquery'], (iframeResize, $) => {
describe('iFrame init(jQuery)', () => {
loadIFrame('iframe600.html')

it('is callable', () => {
const iframe = $('iframe').iframeResize({
license: 'GPLv3',
log: true,
warningTimeout: 100,
})[0]

tearDown(iframe)
})

xit('should create iFrameResizer object', (done) => {
$('iframe').iframeResize({
license: 'GPLv3',
Expand Down
Loading