Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix append with longer words #3

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

somlyaiz
Copy link

Hi David,

You have a great library. I found an issue with your custom StringBuilder, it doesn't increase the backing array's size enough, when a word longer than the current array size is appended.

I hope you'll find it useful.

Zoltan

@codecov-io
Copy link

Codecov Report

Merging #3 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #3      +/-   ##
============================================
+ Coverage     96.59%   96.64%   +0.04%     
- Complexity      115      117       +2     
============================================
  Files             5        5              
  Lines           294      298       +4     
  Branches         45       46       +1     
============================================
+ Hits            284      288       +4     
  Misses            6        6              
  Partials          4        4
Impacted Files Coverage Δ Complexity Δ
...java/org/davidmoten/text/utils/StringBuilder2.java 100% <100%> (ø) 20 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f97030...2f79351. Read the comment docs.

Copy link
Owner

@davidmoten davidmoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you very much!

@davidmoten davidmoten merged commit 9923f08 into davidmoten:master Mar 11, 2019
@davidmoten
Copy link
Owner

I've merged your fix and deployed it to Maven Central in version 0.1.6. Thanks again!

@somlyaiz
Copy link
Author

Thanks, great!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants