Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improved Formatting functionality #85

Closed
wants to merge 1 commit into from

Conversation

EvanZhouDev
Copy link

Fixed executing any of the formatting options on a blank selection.

Original Behavior: Injected prefix, and suffix, and selected the prefix and suffix (with nothing in the middle!)
Expected/New Behavior: Injects prefix and suffix before and after your mouse cursor.

Fixed focus after formatting

Original Behavior: Whenever any of the format buttons are pressed, the formatting is finished, but the focus is transferred onto the format button.
Expected/New Behavior: Whenever any of the format buttons are pressed, the formatting is finished, focus should be restored to the textbox. When the selection is empty, the cursor is simply moved between prefix and suffix. When selection is not empty, the formatted section is still selected, but also focused, as per standard text editors.

This PR fixes the issue presented in #83, as well as some additional things that I felt were related.

@EvanZhouDev
Copy link
Author

I will reopen this later, I am fixing a few things.

@EvanZhouDev EvanZhouDev closed this Apr 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant