Verify that the behavior flag warning fires once #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
mikealfare
commented
Sep 20, 2024
| @@ -2,7 +2,7 @@ | |||
| git+https://github.com/dbt-labs/dbt-core.git#subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-adapters.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter | |||
| git+https://github.com/dbt-labs/dbt-common.git | |||
| git+https://github.com/dbt-labs/dbt-common.git@behavior-flags-fire-once | |||
There was a problem hiding this comment.
Point this back to main
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #915
Problem
We're firing a lot of warnings. We fixed the issue in dbt-common, but we want to make sure it carries through here.
Solution
Trigger the warning a few times in different scenarios and verify that we get one warning per invocation.
Checklist