Return errors when swap_nonatomic fails
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Sep 7, 2018
src/lib.rs
Outdated
| @@ -40,21 +40,23 @@ pub fn swap_nonatomic<A, B>(a: A, b: B) -> io::Result<()> where A: AsRef<Path>, | |||
|
|
|||
| match fs::rename(b, a) { | |||
| Ok(_) => (), | |||
| Err(_) => { | |||
| Err(e) => { | |||
There was a problem hiding this comment.
Since we're not using e directly, Err(e) can be matched by error or other variable name.
andresilva
approved these changes
Sep 10, 2018
dvdplm
approved these changes
Sep 10, 2018
debris
approved these changes
Sep 11, 2018
|
thanks! published in |
This was referenced Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't silently fail when non-atomic swap fails