-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test suite currently broken #663
Comments
Merged your PR, thanks Myles! |
Rad! Would you be able to publish a new version to fix the test suite? It
is currently broken I'm Citgm the smoke test suite we use for testing
releases of node core
…On Sat, Dec 22, 2018, 8:27 AM Qix ***@***.*** wrote:
Closed #663 <#663>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#663 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV6yAsnTATFDJMXsIkDIyHk4MfBMqks5u7jNWgaJpZM4ZfX9C>
.
|
Sure I'll backport it. Just a minute. |
Published as |
We grab the tarball of the tag from GitHub, not the published module from
npm.
It should hopefully work, otherwise we'll likely have to remove the module
from citgm
…On Sat, Dec 22, 2018, 11:41 AM Qix ***@***.*** wrote:
Published as 4.1.1 along with another bugfix - but I'm curious, how does
publishing help? Published versions don't have testing harnesses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#663 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAecVzFnvNP_5o6RWMIx46XyhAJZoHBDks5u7mCygaJpZM4ZfX9C>
.
|
Ah okay, I don't see why it wouldn't. Let me know. |
confirming it works as expected in citgm now. Thanks for the backport |
No problem, glad it's working. |
This was referenced Aug 13, 2019
This was referenced Oct 17, 2019
This was referenced Oct 26, 2019
This was referenced Dec 4, 2019
This was referenced Mar 8, 2020
This was referenced Mar 12, 2021
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: