Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserify and supply alternative unpkg entry point #607

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Conversation

Qix-
Copy link
Member

@Qix- Qix- commented Sep 11, 2018

Closes #606.
Ref #603.

This restores Browserify functionality when debug is used as a nested module. It also fixes the unpkg use case (though in reality there should be a better, more standard way to do this).

However, it's the least intrusive way to fix both problems. I can't guarantee that the unpkg solution works, but users should be pinning versions anyway and not using debug@* on live sites.

cc @mjackson - if you have any input as to how to support unpkg in a less domain-specific way, that'd be great.

@Qix- Qix- self-assigned this Sep 11, 2018
@@ -11,7 +11,7 @@ dist: dist/debug.js dist/test.js
.INTERMEDIATE: dist/debug.es6.js
dist/debug.es6.js: src/*.js
@mkdir -p dist
browserify --standalone debug $< > $@
browserify --standalone debug . > $@
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this to make sure browserify configurations in the future work as intended.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.111% when pulling ab72571 on fix-browserify into 7fb104b on master.

@Qix- Qix- added the change-patch This proposes or provides a change that requires a patch release label Sep 11, 2018
@Qix- Qix- merged commit 99c95e3 into master Sep 11, 2018
@Qix- Qix- deleted the fix-browserify branch September 11, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-patch This proposes or provides a change that requires a patch release
Development

Successfully merging this pull request may close these issues.

debug no longer works with browserify
2 participants