Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching enabled status per logger #799

Merged
merged 2 commits into from
Dec 9, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ function setup(env) {
function createDebug(namespace) {
let prevTime;
let enableOverride = null;
let namespacesCache, enabledCache;
containmentbreach marked this conversation as resolved.
Show resolved Hide resolved

function debug(...args) {
// Disabled?
Expand Down Expand Up @@ -120,7 +121,17 @@ function setup(env) {
Object.defineProperty(debug, 'enabled', {
enumerable: true,
configurable: false,
get: () => enableOverride === null ? createDebug.enabled(namespace) : enableOverride,
get: () => {
if (enableOverride !== null) {
return enableOverride
containmentbreach marked this conversation as resolved.
Show resolved Hide resolved
}
if (namespacesCache !== createDebug.namespaces) {
namespacesCache = createDebug.namespaces;
enabledCache = createDebug.enabled(namespace);
}
return enabledCache;

containmentbreach marked this conversation as resolved.
Show resolved Hide resolved
},
set: v => {
enableOverride = v;
}
Expand Down Expand Up @@ -149,6 +160,7 @@ function setup(env) {
*/
function enable(namespaces) {
createDebug.save(namespaces);
createDebug.namespaces = namespaces;

createDebug.names = [];
createDebug.skips = [];
Expand Down