Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate uni-resolver-web to Spring Boot #271

Merged
merged 12 commits into from
Jan 5, 2022
Merged

Migrate uni-resolver-web to Spring Boot #271

merged 12 commits into from
Jan 5, 2022

Conversation

cihanss
Copy link
Member

@cihanss cihanss commented Jan 5, 2022

This PR includes changes for spring-boot migration alongside the following:

  • log4j2 configurations are changed from properties to XML format, and the log pattern has changed
  • uni-resolver-web component is packaged in a jar instead of a war
  • the webapp files are not utilized but left as they were
  • docker image changed to openjdk:11-jre-slim
  • dev profile and its corresponding environment variable added to test spring metrics

This closes #259

@cihanss
refactor: Migrate to Spring Boot
5df98bc
@cihanss
feat: Add spring profile "dev"
d7aa6cb
@cihanss
chore(deps): Bump jetty version to 9.4.44.v20210927
31ba9ee
@cihanss
chore(deps): Bump spring-framework version to 5.3.14
5a9419b
@cihanss
refactor(deps): Add log4j2 and micrometer dependencies
aed76ac
@cihanss
refactor(logs): Use log4j2 xml configurations
75af4e0
@cihanss
refactor: Rename variable universal_resolver_web_spring_profiles_acti…
582c3a0 
…ve to uniresolver_web_spring_profiles_active
@cihanss
refactor: Update pom file
86cf581 
- Bump spring-boot version to 2.6.2
- Change packaging from war to jar
- Remove explicit log4j dependencies
@cihanss
refactor(build): Add execution goal repackage
cf0b46f
@cihanss
refactor(build): Update Dockerfile
45a69c5 
- Change image from jetty:9.4-jre11 to openjdk:11-jre-slim
- Use WORKDIR
- Adjust CMD command for executing .jar app
@cihanss
refactor(build): Add classifier config into repackage goal
ec88734
@cihanss
refactor(config): Remove shutdown and application tag configs
4487e34
@cihanss cihanss added enhancement dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 5, 2022
peacekeeper
peacekeeper approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally, seems to work fine! I think this change will be very useful in various deployments of the UR..

@BernhardFuchs BernhardFuchs merged commit 17db137 into main Jan 5, 2022
@cihanss cihanss deleted the spring-boot-migration-1 branch June 7, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacekeeper peacekeeper peacekeeper approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Universal Resolver to Spring Boot
3 participants
@cihanss @peacekeeper @BernhardFuchs