secp256k1: Test consistency cleanup and rework. #2887

This makes several of the benchmarks more consistent in terms of resetting the timer and reporting memory allocations as well as moves the ones that only apply when accessing the package via the standard library elliptic curve adaptor code to a new file named ellipticadaptor_bench_test.go. It also converts the ecdsa signature verification benchmark to use bytes directly instead of standard lib big ints and remove the no longer necessary hexToBigInt helper.

In order to simplify and consolidate the test logic that ensures test points in Jacobian coordinates are valid group elements, this modifies the test helper function that determines if a given Jacobian point is on the secp256k1 curve to also check for the point at infinity, renames it to isValidJacobianPoint, and updates all callers accordingly.

In order to simplify and consolidate the test logic that ensures test points in affine coordinates are valid group elements, this introduces a new test helper function that determines if a given affine point is on the secp256k1 curve or is the point at infinity and updates all callers accordingly.

This cleans up the tests for performing affine addition to make them more consistent with modern practices in the code and also moves them to the ellipticadaptor_test.go file since they only apply when accessing the package via the standard library elliptic curve adaptor code. The following is a high level overview of the changes: - Renames TestAddAffine to TestAddAffineAdaptor to make it clear it is testing via the adaptor - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code

This cleans up the tests for performing affine point doubling to make them more consistent with modern practices in the code and also moves them to the ellipticadaptor_test.go file since they only apply when accessing the package via the standard library elliptic curve adaptor code. The following is a high level overview of the changes: - Renames TestDoubleAffine to TestDoubleAffineAdaptor to make it clear it is testing via the adaptor - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code

This cleans up the test for key generation to make it more consistent with modern practices in the code and also moves it to the privkey_test.go file since the associated function is defined in privkey.go. The following is a high level overview of the changes: - Rename TestKeyGeneration to TestGeneratePrivateKey to match the func name - Remove the curve-based indirection since it only works with secp256k1

This cleans up the tests for performing affine scalar point multiplication to make them more consistent with modern practices in the code and also moves them to the ellipticadaptor_test.go file since they only apply when accessing the package via the standard library elliptic curve adaptor code. The following is a high level overview of the changes: - Renames TestScalarMult to TestScalarMultAdaptor to make it clear it is testing via the adaptor - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code - Adds some additional edge cases

This cleans up the tests for performing affine scalar base multiplication to make them more consistent with modern practices in the code. The following is a high level overview of the changes: - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code - Adds some additional edge cases

This cleans up the test for performing affine scalar base multiplication with random scalars to make it more consistent with modern practices in the code and also moves it to the ellipticadaptor_test.go file since it only applies when accessing the package via the standard library elliptic curve adaptor code. The following is a high level overview of the changes: - Adds a randBytes convenience func to acquire a specified number of random bytes from a given rng - Renames TestBaseMultVerify to TestScalarBaseMultAdaptorRandom to make it clear it is testing via the adaptor and based on random values - Uses a new seed for each invocation to ensure new random values are tested each run as opposed to always testing the same random values generated by the same seed

This cleans up the test for key generation to make it more consistent with modern practices in the code and adds a couple more test cases.

This cleans up the tests for performing Jacobian addition to make them more consistent with modern practices in the code. The following is a high level overview of the changes: - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code

This cleans up the tests for performing Jacobian point doubling to make them more consistent with modern practices in the code. The following is a high level overview of the changes: - Adds names to each individual test for easier identification - Makes the individual test definitions consistent with the rest of the code

This adds a new test helper for generating random mod n scalars without also generating a companion big integer and updates the tests to make use of it. It also marks the combined version as a test helper while here. The new helper will be useful for future tests.

This adds tests for scalar base multiplication for points projected in Jacobian coordinates.

This reworks the tests that deal with scalar point multiplication with points projected into Jacobian coordinates for randomly-generated scalars and points to make them more consistent with modern practices in the code as well as to expand the testing methodology to include additional assurances. It also updates the tests to ensure new random values are tested each run as opposed to the existing tests which always test the same values since they use the same random seed. Specifically: - The points are no longer converted to affine with each iteration which ensures z values other than 1 are tested - Each iteration now ensures calculating the negative version of the point and adding it results in the point at infinity - The check to ensure the same final point was calculated is now done outside of the loop to speed up the test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

secp256k1: Test consistency cleanup and rework. #2887

secp256k1: Test consistency cleanup and rework. #2887

Commits on Mar 10, 2022