blockchain: Optimize old block ver upgrade checks. #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_optimize_old_block_ver_checks
branch
from
f213eed
to
41e412c
Compare
rstaudt2
approved these changes
Mar 31, 2022
dnldd
approved these changes
Mar 31, 2022
JoeGruffins
approved these changes
Apr 6, 2022
Currently the code that rejects old block versions once the majority of the network has upgraded is performed using a loop that iterates backwards from latest enforced block version while checking for a majority upgrade at each version. This is inefficient for blocks early in the chain since it means multiple versions need to be checked when it isn't really necessary. This optimizes the relevant code by taking into account that the relevant enforcement semantics reduce to the following: - Block versions greater than or equal to the latest enforced block version can never be rejected for being old - Block versions must be rejected when the majority of the network has upgraded to ANY version greater than that version The following timing information obtained from profiling shows the overall reduction achieved with the optimized code for mainnet: existing: Total time to check old versions for 645603 headers: 10.61118s optimized: Total time to check old versions for 645603 headers: 3.52555s
davecgh
force-pushed
the
blockchain_optimize_old_block_ver_checks
branch
from
41e412c
to
5a3f082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code that rejects old block versions once the majority of the network has upgraded is performed using a loop that iterates backwards from latest enforced block version while checking for a majority upgrade at each version. This is inefficient for blocks early in the chain since it means multiple versions need to be checked when it isn't really necessary.
This optimizes the relevant code by taking into account that the relevant enforcement semantics reduce to the following:
The following timing information obtained from profiling shows the overall reduction achieved with the optimized code for mainnet: