secp256k1/ecdsa: Add compact signature tests. #2915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2914.
This adds tests for compact signature generation and associated public key recovery for both the positive and negative paths and reworks the tests that deal with signing random messages with random private keys and recovering the associated public key to make them more consistent with modern practices in the code as well as to expand the testing methodology to include additional assurances.
The following is a high-level overview of the changes: