blockchain: Remove unspendable utxo set entries. #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
non-forking consensus
|
Looks good overall, will be running the upgrade soon on mainnet. |
davecgh
commented
Sep 15, 2022
davecgh
force-pushed
the
blockchain_remove_treasurybase_utxos
branch
from
542b10c
to
836636b
Compare
|
Upgrade completed without issue on mainnet. 2022-09-16 10:38:45.413 [INF] CHAN: UTXO cache initializing (max size: 150 MiB)...
2022-09-16 10:38:45.413 [INF] CHAN: Upgrading UTXO database to version 3...
2022-09-16 10:38:45.413 [INF] CHAN: Updating database utxo set. This may take a while...
2022-09-16 10:38:45.537 [INF] CHAN: Removed 50000 unspendable outputs (50000 total)
2022-09-16 10:38:45.792 [INF] CHAN: Removed 50000 unspendable outputs (100000 total)
2022-09-16 10:38:45.937 [INF] CHAN: Removed 16947 unspendable outputs (116947 total)
2022-09-16 10:38:46.006 [INF] CHAN: Done updating UTXO database. Total unspendable outputs removed: 116947 in 594ms
2022-09-16 10:38:46.030 [INF] CHAN: Done upgrading database in 617ms.
2022-09-16 10:38:46.030 [INF] CHAN: UTXO cache initialization completed |
dnldd
approved these changes
Sep 16, 2022
JoeGruffins
approved these changes
Sep 28, 2022
This modifies the upgrade code for the utxo database to ensure the local instance of the utxo database info is updated by passing it into the relevant upgrade functions so that multiple upgrades in a row are possible. This makes it consistent with the blockchain database upgrade code.
This adds code to update the utxodb to version 3 which removes outputs from the utxo set that are never directly spendable to avoid needlessly wasting space.
davecgh
force-pushed
the
blockchain_remove_treasurybase_utxos
branch
from
836636b
to
d1b381d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2995.
Testing Notes
As of this PR, the expected behavior is that there is a single database update that takes around 1 to 2 seconds to complete after which it will no longer be possible to downgrade.
As the warning above notes, if you try to run an older software version after this migration has completed, you will get an error message similar to
Unable to start server: the current UTXO database is no longer compatible with this version of the software (3 > 2)This adds code to update the utxo database to version 3 which removes outputs from the utxo set that are never directly spendable to avoid needlessly wasting space.