Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Make sure the peer address exists in the manager. #3013

Merged
merged 1 commit into from
Oct 22, 2022
Merged

server: Make sure the peer address exists in the manager. #3013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,9 +723,13 @@ func (sp *serverPeer) OnVersion(_ *peer.Peer, msg *wire.MsgVersion) {
remoteAddr := wireToAddrmgrNetAddress(sp.NA())
addrManager := sp.server.addrManager
if !cfg.SimNet && !cfg.RegNet && !isInbound {
// Be sure the address exists in the address manager.
addrManager.AddAddresses([]*addrmgr.NetAddress{remoteAddr},
remoteAddr)

err := addrManager.SetServices(remoteAddr, msg.Services)
if err != nil {
srvrLog.Debugf("Setting services for address failed: %v", err)
srvrLog.Errorf("Setting services for address failed: %v", err)
}
}

Expand Down Expand Up @@ -777,7 +781,7 @@ func (sp *serverPeer) OnVersion(_ *peer.Peer, msg *wire.MsgVersion) {
// Mark the address as a known good address.
err := addrManager.Good(remoteAddr)
if err != nil {
srvrLog.Debugf("Marking address as good failed: %v", err)
srvrLog.Errorf("Marking address as good failed: %v", err)
}
}

Expand Down