Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: Decouple RPC agenda info status strings. #3071

Commits on Mar 5, 2023

  1. rpcserver: Decouple RPC agenda info status strings.

    Similar to the case that previously existed for getblockchainfo,
    currently, the getvoteinfo RPC implementation directly returns the
    internal threshold state strings defined in blockchain.  This is not
    ideal since it means that any changes to the internal implementation
    could inadvertently change the RPC results without being noticed.
    
    Further, the blockchain package is now internal which means external
    callers don't have access to those constants.
    
    Consequently, this makes the same change to getvoteinfo as was
    previously made to getblockchaininfo to decouple the agenda status
    strings by converting the internal blockchain threshold state to use the
    agenda status string constants defined in the rpc/jsonrpc/types module.
    davecgh committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    83b7f16 View commit details
    Browse the repository at this point in the history