Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staking,ui: implement live ui updates for ticket price, stats #2497

Closed
buck54321 opened this issue Sep 1, 2023 · 2 comments · Fixed by #2540
Closed

staking,ui: implement live ui updates for ticket price, stats #2497

buck54321 opened this issue Sep 1, 2023 · 2 comments · Fixed by #2540
Labels
UI wallet Client wallet backends

Comments

@buck54321
Copy link
Member

As pointed out here, the ticket price does not update as the chain progresses, and we might consider disabling ticket purchasing during initial sync.

Other sync-related tasks to consider are updating of ticket statuses for for tickets in the ticketPage.history, and updating of displayed statistics.

@buck54321 buck54321 added wallet Client wallet backends UI labels Sep 1, 2023
@peterzen
Copy link
Member

Would the following approach be acceptable?

  • During initial sync:

    • display the Staking box in a disabled state (if the wallet being used has staking support, otherwise keep it hidden)
  • After initial sync:

    • Enable staking box/VSP picker/ticket purchasing
    • Periodically (every 10 mins) call updateTicketBuyer() to obtain ticket stats and update staking box

@buck54321
Copy link
Member Author

Add the ticket price data to the (*WalletEmitter).TipChange notification. Can probably add ticket stats there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI wallet Client wallet backends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants