multi: gui staking #2482

buck54321 · 2023-08-19T16:15:59Z

Enables the following staking related features through the client GUI

Select a VSP
Viewi current ticket price and voting rewards
Purchase tickets
View historical wallet staking stats
View a paginated table of wallet tickets
View agenda, tspends, and pi keys and update voting preferences

Implementation is minimal. My goal is to get a basic framework for staking on the front end. We can get all the bells and whistles added later.

There are still some unresolved questions around staking in general, marked with DRAFT NOTE:, though I am not opening this PR in draft because it's ready for review.

Tickets statuses are not updated on the front end. The front end has no tip change notification. If there was a tip change notification and we requested a new TicketStakingStatus every block, merging that info with the existing front-end state will require some finesse. e.g. if a user is looking at the paginated ticket table, we can't just delete the current history underneath of them, as it would be inefficient and it would cause errors when the user tried to navigate. Leaving this as a project for later.

dcrwallet's PurchaseTickets sometimes reduces the number of tickets purchased if there some utxo math it doesn't like. This is obviously terrible for UX, so a solution is needed. See draft notes.

martonp

Working well, just noticed some issues. No matter how many tickets I try to buy, it always only buys one ticket. After I buy a ticket, and the block has not yet been mined, if I try to buy another one it will say "insufficient funds", but the wallet page shows I have plenty of funds.

client/asset/dcr/spv.go

martonp · 2023-08-21T11:07:44Z

client/asset/dcr/spv.go

+		endBlock = wallet.NewBlockIdentifierFromHeight(upperHeight)
+	}
+	if lowerHeight == lowerHeightAutomatic {
+		bn := upperHeight - int32(p.TicketExpiry+uint32(p.TicketMaturity)-requiredConfs)


What's the reason for subtracting requiredConfs and why is it 6 + 2?

I see this in dcrwallet, and I probably copied it from there, but unsure what it is about. Unless it wants the block when the ticket purchasing started? If the mined block it should be revoked after p.TicketExpiry+p.TicketMaturity?

https://github.com/decred/dcrwallet/blob/a87fa843495ec57c1d3b478c2ceb3876c3749af5/wallet/wallet.go#L5911

It's used in ForUnspentUnexpiredTickets without comment, but yes, I agree it seems unneeded. I guess I'll just remove it.

client/asset/interface.go

buck54321 · 2023-08-21T23:52:45Z

Working well, just noticed some issues. No matter how many tickets I try to buy, it always only buys one ticket. After I buy a ticket, and the block has not yet been mined, if I try to buy another one it will say "insufficient funds", but the wallet page shows I have plenty of funds.

I've got a DRAFT NOTE: about it in (*spvWallet).PurchaseTickets.

// DRAFT NOTE: When purchasing N tickets, if there is utxo contention, the
// dcrwallet algorithm will reduce the Count until resolved.
// https://github.com/decred/dcrwallet/blob/a87fa843495ec57c1d3b478c2ceb3876c3749af5/wallet/createtx.go#L1480-L1490
// As a result, the user will get an actual ticket count somewhere in the
// range 1 <= tickets_purchased <= n.
// How do we handle that here? Or do we just let the front end handle it?
// If we set MinConf to 0 can we just loop until we have enough?

I can try to loop and see if that works.

JoeGruffins

Looks great! It looks like the simnet vspd cannot handle the vote ids. Should we use a newer vspd version or is that not the issue?

Will try this out on testnet.

client/asset/dcr/dcr.go

client/asset/dcr/rpcwallet.go

JoeGruffins · 2023-08-25T08:18:15Z

client/asset/dcr/spv.go

+		// DRAFT NOTE: Why not 0? We count zero-conf as available, so this
+		// doesn't match.
 		MinConf:              1,


I guess 0 is fine.

Changed to zero. For SPV wallets, new outputs aren't even seen until they have 1 confirmation, so any zero confirmation outputs seen by an spv wallet would be our own e.g. change outputs.

JoeGruffins · 2023-08-25T08:55:52Z

client/asset/dcr/spv.go

+		endBlock = wallet.NewBlockIdentifierFromHeight(upperHeight)
+	}
+	if lowerHeight == lowerHeightAutomatic {
+		bn := upperHeight - int32(p.TicketExpiry+uint32(p.TicketMaturity)-requiredConfs)


I see this in dcrwallet, and I probably copied it from there, but unsure what it is about. Unless it wants the block when the ticket purchasing started? If the mined block it should be revoked after p.TicketExpiry+p.TicketMaturity?

https://github.com/decred/dcrwallet/blob/a87fa843495ec57c1d3b478c2ceb3876c3749af5/wallet/wallet.go#L5911

client/core/core.go

itswisdomagain · 2023-08-25T14:01:54Z

Seems it's not currently possible / allowed to change the VSP?

JoeGruffins

Working on testnet! But as Wisdom said cannot change the vsp in the UI after choosing one.

JoeGruffins · 2023-08-28T07:54:13Z

It also seems it will show the ticket price as it syncs, so will have wrong info that could be way off during initial sync. Maybe should disable purchasing if not synced anyway?

buck54321 · 2023-08-30T13:28:52Z

It looks like the simnet vspd cannot handle the vote ids. Should we use a newer vspd version or is that not the issue?

What are you seeing, @JoeGruffins? I'm on vspd version 1.2.1+ee0a6fa5b and I don't see any issues.

buck54321 · 2023-08-30T14:14:09Z

Seems it's not currently possible / allowed to change the VSP?

Fixed in 35c2516

buck54321 · 2023-08-30T14:15:27Z

It also seems it will show the ticket price as it syncs, so will have wrong info that could be way off during initial sync. Maybe should disable purchasing if not synced anyway?

Yes. Will leave this for followup.

buck54321 · 2023-08-30T18:23:23Z

I think #2492 will be a big help for us with remaining hurdles for staking, and with other new wallet features. I don't plan on waiting for that here. Once this PR is merged, we can start addressing remaining issues with separate, targeted efforts.

JoeGruffins · 2023-08-31T03:22:00Z

What are you seeing, @JoeGruffins? I'm on vspd version 1.2.1+ee0a6fa5b and I don't see any issues.

oh. doh. It's my installed version is the problem. Let me update and try again.

JoeGruffins · 2023-08-31T04:42:24Z

$ vspd --homedir=/home/joe/dextest/dcr/vspd; tmux wait-for -S vspd loadConfig error: error parsing config file: /home/joe/dextest/dcr/vspd/vspd.conf:2: Invalid value simnet' for option --network'. Allowed values are: testnet or mainnet grr

JoeGruffins · 2023-08-31T04:50:08Z

decred/vspd#419

JoeGruffins

My vspd install was the problem. Looks great.

martonp reviewed Aug 21, 2023

View reviewed changes

JoeGruffins approved these changes Aug 25, 2023

View reviewed changes

JoeGruffins approved these changes Aug 28, 2023

View reviewed changes

buck54321 added 9 commits August 28, 2023 17:22

core and webserver

1fca0e1

select a vsp

72c489c

checkpoint

f70fdf6

purchase tickets. show history

d684fb7

stats

8b8f612

pagination

65cd12f

add voting

8ee3be6

check with rpc

e6854f5

docs and touchups

db3974e

enable changing of vsp. martonp and joegruff reviews

35c2516

buck54321 force-pushed the staking-ui branch from 32fe289 to 35c2516 Compare August 30, 2023 14:10

buck54321 mentioned this pull request Aug 30, 2023

client/{asset,core}: wallet notifications #2492

Merged

JoeGruffins approved these changes Aug 31, 2023

View reviewed changes

JoeGruffins mentioned this pull request Aug 31, 2023

config: Add back simnet. decred/vspd#419

Merged

buck54321 merged commit 1b79545 into decred:master Sep 1, 2023
5 checks passed

buck54321 mentioned this pull request Sep 1, 2023

staking,ui: implement live ui updates for ticket price, stats #2497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi: gui staking #2482

multi: gui staking #2482

buck54321 commented Aug 19, 2023

martonp left a comment

martonp Aug 21, 2023

JoeGruffins Aug 25, 2023

buck54321 Aug 30, 2023

buck54321 commented Aug 21, 2023

JoeGruffins left a comment

JoeGruffins Aug 25, 2023

buck54321 Aug 30, 2023

JoeGruffins Aug 25, 2023

itswisdomagain commented Aug 25, 2023

JoeGruffins left a comment

JoeGruffins commented Aug 28, 2023

buck54321 commented Aug 30, 2023 •

edited

Loading

buck54321 commented Aug 30, 2023

buck54321 commented Aug 30, 2023

buck54321 commented Aug 30, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins left a comment

multi: gui staking #2482

multi: gui staking #2482

Conversation

buck54321 commented Aug 19, 2023

martonp left a comment

Choose a reason for hiding this comment

martonp Aug 21, 2023

Choose a reason for hiding this comment

JoeGruffins Aug 25, 2023

Choose a reason for hiding this comment

buck54321 Aug 30, 2023

Choose a reason for hiding this comment

buck54321 commented Aug 21, 2023

JoeGruffins left a comment

Choose a reason for hiding this comment

JoeGruffins Aug 25, 2023

Choose a reason for hiding this comment

buck54321 Aug 30, 2023

Choose a reason for hiding this comment

JoeGruffins Aug 25, 2023

Choose a reason for hiding this comment

itswisdomagain commented Aug 25, 2023

JoeGruffins left a comment

Choose a reason for hiding this comment

JoeGruffins commented Aug 28, 2023

buck54321 commented Aug 30, 2023 • edited Loading

buck54321 commented Aug 30, 2023

buck54321 commented Aug 30, 2023

buck54321 commented Aug 30, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins commented Aug 31, 2023

JoeGruffins left a comment

Choose a reason for hiding this comment

buck54321 commented Aug 30, 2023 •

edited

Loading