client/asset: Add WalletHistorian interface and RPC method #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
force-pushed
the
walletHistorian
branch
2 times, most recently
from
4506720
to
42bc5dc
Compare
martonp
changed the title
This adds a `WalletHistorian` interface which exposes a `TxHistory` function. This will allow wallets to display the history of their transactions. Also adds a method to the RPC server to retrieve the wallet history.
martonp
force-pushed
the
walletHistorian
branch
from
42bc5dc
to
fcbbdad
Compare
|
CI failure is unrelated: #2505 |
JoeGruffins
approved these changes
Sep 7, 2023
Comment on lines
+1059
to
+1069
| // WalletHistorian is a wallet that is able to retrieve the history of all | ||
| // transactions it has made. | ||
| type WalletHistorian interface { | ||
| // TxHistory returns all the transactions a wallet has made. If refID | ||
| // is nil, then transactions starting from the most recent are returned | ||
| // (past is ignored). If past is true, the transactions prior to the | ||
| // refID are returned, otherwise the transactions after the refID are | ||
| // returned. n is the number of transactions to return. If n is <= 0, | ||
| // all the transactions will be returned. | ||
| TxHistory(n int, refID *dex.Bytes, past bool) ([]*WalletTransaction, error) | ||
| } |
There was a problem hiding this comment.
If there are a lot of transactions, this could be pretty big. Maybe add a hard limit?
There was a problem hiding this comment.
I think the front ends should handle that. I'll update the RPC server to have a default of 10. Would something go wrong if too many are requested?
buck54321
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
WalletHistorianinterface which exposes aTxHistoryfunction. This will allow wallets to display the history of their
transactions. Also adds a method to the RPC server to retrieve the
wallet history.