Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOB panic in spent ticket scanner. #423

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix OOB panic in spent ticket scanner. #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd31972
vspd: Fix OOB panic in spent ticket scanner.
jholdstock Sep 5, 2023
a57a5e8
vspd: Stop scanning when ticket spender found.
jholdstock Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/vspd/spentticket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func (v *vspd) findSpentTickets(toCheck database.TicketList, startHeight int64)
return nil, 0, err
}

for i := range tickets {
for i := 0; i < len(tickets); i++ {
// The regular transaction tree does not need to be checked because
// tickets can only be spent by vote or revoke transactions which
// are always in the stake tree.
Expand All @@ -172,6 +172,9 @@ func (v *vspd) findSpentTickets(toCheck database.TicketList, startHeight int64)
// Current index has been removed which means everything else
// moved up one and thus the same index needs to be repeated.
i--

// Check next ticket.
break
}
}

Expand Down
Loading