Break up and rename blockConnected function #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name blockConnected is not very accurate as this function is also called when vspd is initializing. It doesnt depend on a block having been connected at all, it can be called at any time.
This splits the code from vspd.go into various other files which broadly represent the functional areas of vspd - the main update function, database intgrity checks and voting wallet consistency checks. Code is just moved without any modifications.
The update function performs four distinct steps which can readily be broken down into four separate functions.
This allows RPC clients to be reused more easily in the case that the caller of findSpentTickets already has a connected dcrd RPC client.
jholdstock
force-pushed
the
breakdown
branch
2 times, most recently
from
8f1ecfd
to
32967c0
Compare
davecgh
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the large vspd.go file into several new files, and the blockConnected function into smaller, more specific functions.
Beyond the fact that small components are easier to maintain and reason about, this is also a step towards providing more granular (and thus more useful) log/error information,.