Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
  • Loading branch information
njzjz and coderabbitai[bot] committed Sep 24, 2024
1 parent cad9034 commit 801f36e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion source/tests/consistent/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def get_reference_ret_serialization(self, ref: RefBackend):
return self.get_jax_ret_serialization_from_cls(obj)
if ref == self.RefBackend.ARRAY_API_STRICT:
obj = self.init_backend_cls(self.array_api_strict_class)
return self.get_array_api_ret_serialization_from_cls(obj)
return self.get_array_api_strict_ret_serialization_from_cls(obj)
raise ValueError("No available reference")

def test_tf_consistent_with_ref(self):
Expand Down
2 changes: 1 addition & 1 deletion source/tests/consistent/descriptor/test_dpa1.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
if INSTALLED_JAX:
from deepmd.jax.descriptor.dpa1 import DescrptDPA1 as DescriptorDPA1JAX
else:
DescrptDPA1JAX = None
DescriptorDPA1JAX = None
if INSTALLED_ARRAY_API_STRICT:
from ...array_api_strict.descriptor.dpa1 import DescrptDPA1 as DescriptorDPA1Strict
else:
Expand Down
1 change: 1 addition & 0 deletions source/tests/consistent/test_type_embedding.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def data(self) -> dict:
array_api_strict_class = TypeEmbedNetStrict
args = type_embedding_args()
skip_jax = not INSTALLED_JAX
skip_array_api_strict = not INSTALLED_ARRAY_API_STRICT

@property
def addtional_data(self) -> dict:
Expand Down

0 comments on commit 801f36e

Please sign in to comment.