Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No share params in self.repinit_three_body in multitask process #4137

Closed
Chengqian-Zhang opened this issue Sep 18, 2024 · 0 comments · Fixed by #4139
Closed

[BUG] No share params in self.repinit_three_body in multitask process #4137

Chengqian-Zhang opened this issue Sep 18, 2024 · 0 comments · Fixed by #4139
Assignees
Labels

Comments

@Chengqian-Zhang
Copy link
Collaborator

Bug summary

In share_params function of DescrptDPA2 module, repinit_three_body module does not share params.

Code:
if shared_level == 0:
self._modules["type_embedding"] = base_class._modules["type_embedding"]
self.repinit.share_params(base_class.repinit, 0, resume=resume)
self._modules["g1_shape_tranform"] = base_class._modules[
"g1_shape_tranform"
]
self.repformers.share_params(base_class.repformers, 0, resume=resume)

You can see only repinit and repformer share params. repinit_three_body does not.

DeePMD-kit Version

newest devel branch

Backend and its version

not related

How did you download the software?

Offline packages

Input Files, Running Commands, Error Log, etc.

No content

Steps to Reproduce

No content

Further Information, Files, and Links

No content

@iProzd iProzd self-assigned this Sep 18, 2024
@iProzd iProzd linked a pull request Sep 18, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
Fix #4137.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced descriptor handling to support three-body interactions,
improving model flexibility.
- Introduced a new model configuration, `model_dpa2tebd`, with advanced
parameters for better performance.

- **Tests**
- Added a new test class, `TestMultiTaskDPA2Tebd`, to expand testing
coverage for the new model configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
Fix #4137.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced descriptor handling to support three-body interactions,
improving model flexibility.
- Introduced a new model configuration, `model_dpa2tebd`, with advanced
parameters for better performance.

- **Tests**
- Added a new test class, `TestMultiTaskDPA2Tebd`, to expand testing
coverage for the new model configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@njzjz njzjz closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants