Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ZBL test path #3757

Merged
merged 4 commits into from
May 7, 2024
Merged

Fix: ZBL test path #3757

merged 4 commits into from
May 7, 2024

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented May 7, 2024

Summary by CodeRabbit

  • Tests
    • Updated the path configuration for the use_srtab key in test settings to enhance reliability by changing from a relative path to an absolute path.
    • Imported os module and defined CUR_DIR as the directory of the current file.

Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

The recent update aims to improve the reliability and portability of a Python test script by transitioning a file path reference from relative to absolute within a dictionary key.

Changes

File Path Change Summary
source/tests/.../test_permutation.py Updated use_srtab key in model_zbl dictionary to an absolute path from a relative one.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Python label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (6c715d1) to head (fc3a048).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3757   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files         513      513           
  Lines       47653    47653           
  Branches     2980     2979    -1     
=======================================
  Hits        39199    39199           
  Misses       7543     7543           
  Partials      911      911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml requested a review from njzjz May 7, 2024 10:19
@njzjz njzjz enabled auto-merge May 7, 2024 16:35
@njzjz njzjz added this pull request to the merge queue May 7, 2024
@njzjz njzjz linked an issue May 7, 2024 that may be closed by this pull request
Merged via the queue into deepmodeling:devel with commit 6f06adb May 7, 2024
60 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Tests**
- Updated the path configuration for the `use_srtab` key in test
settings to enhance reliability by changing from a relative path to an
absolute path.
- Imported `os` module and defined `CUR_DIR` as the directory of the
current file.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.pt.test_training.TestEnergyZBLModelSeA.test_dp_train failed
2 participants