Fix code scanning alert #2: Arbitrary file write during tarfile extraction

[njzjz]

Fixes https://github.com/deepmodeling/deepmd-kit/security/code-scanning/2

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by CodeRabbit

• New Features

  • Enhanced security for file extraction by implementing additional checks to prevent path traversal vulnerabilities.

• Bug Fixes

  • Strengthened safeguards against unauthorized file access during file extraction.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The changes introduced in this pull request enhance the safe_extract function in the build_tf.py file by adding security checks to prevent path traversal vulnerabilities. The new checks ensure that extracted file paths are not absolute or do not contain parent directory references. These modifications reinforce the function's security against unauthorized file access while maintaining the existing logic.

Changes

Files	Change Summary
source/install/build_tf.py	Added security checks to the safe_extract function to prevent path traversal vulnerabilities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant safe_extract
    participant TarArchive

    User->>TarArchive: Request to extract files
    TarArchive->>safe_extract: Pass file members for extraction
    safe_extract->>safe_extract: Check if path is absolute or contains ".."
    alt Valid path
        safe_extract->>TarArchive: Extract file
    else Invalid path
        safe_extract-->>User: Raise exception
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.