fix(pt): fix compute_output_stats_global when atomic_output is None

[njzjz]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling by ensuring that the output data is not None before processing, preventing potential runtime errors.

[coderabbitai]

Walkthrough

Walkthrough

The change involves a modification to the compute_output_stats_global function in the deepmd/pt/utils/stat.py file. The update enhances a conditional check to include a verification that the atomic_output is not None before accessing its properties. This adjustment aims to prevent errors related to dereferencing a None object during the execution of the function.

Changes

File	Change Summary
deepmd/pt/utils/stat.py	Modified a conditional check in compute_output_stats_global to ensure atomic_output is not None before accessing its data.

Sequence Diagram(s)

sequenceDiagram
    participant A as Caller
    participant B as compute_output_stats_global
    participant C as atomic_output

    A->>B: Call compute_output_stats_global()
    B->>C: Check if atomic_output is not None
    alt atomic_output is not None
        B->>C: Access properties of atomic_output
    else atomic_output is None
        B->>A: Return error or handle None case
    end

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6010c73 and 5ac6729.

Files selected for processing (1)

• deepmd/pt/utils/stat.py (1 hunks)

Additional comments not posted (1)

deepmd/pt/utils/stat.py (1)

481-481: LGTM! The added condition improves code safety.

The updated condition adds a necessary safety check to ensure that atomic_output is not None before accessing its get_data() method and the intensive property. This change prevents potential runtime errors and enhances the robustness of the code by gracefully handling the case when atomic_output is not provided.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (6010c73) to head (5ac6729).
Report is 1 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #4155   +/-   ##
=======================================
  Coverage   83.41%   83.42%           
=======================================
  Files         532      532           
  Lines       52048    52048           
  Branches     3046     3046           
=======================================
+ Hits        43416    43419    +3     
+ Misses       7684     7682    -2     
+ Partials      948      947    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.