support converting models generated in v1.3 to 2.0 compatibility #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
By the way: Compatability should be compatibility
Codecov Report
@@ Coverage Diff @@
## devel #725 +/- ##
==========================================
- Coverage 74.30% 74.07% -0.23%
==========================================
Files 82 78 -4
Lines 6534 6561 +27
==========================================
+ Hits 4855 4860 +5
- Misses 1679 1701 +22
Continue to review full report at Codecov.
|
njzjz
changed the title
njzjz
changed the title
|
@amcadmus I've changed the implementation: Now users can converting models directly using v2.0. There's no necessity to install the old version. |
amcadmus
reviewed
Jun 22, 2021
| @@ -25,6 +25,26 @@ REGISTER_OP("ProdEnvMatA") | |||
| .Output("nlist: int32"); | |||
| // only sel_a and rcut_r uesd. | |||
|
|
|||
| // an alias of ProdEnvMatA -- Compatible with v1.3 | |||
| REGISTER_OP("DescrptSeA") | |||
There was a problem hiding this comment.
Do we need to register DescrptSeA? the op name has changed to ProdEnvMatA by convert
There was a problem hiding this comment.
We need to load the old graph first when executing convert.
amcadmus
approved these changes
Jun 22, 2021
denghuilu
approved these changes
Jun 22, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
…pmodeling#725) * add v1.3 compatibility * remove TestModelMajorCompatability as compatibility was added By the way: Compatability should be compatibility * Also remove TestModelMinorCompatability * Update test_deeppot_a.py * Revert "Update test_deeppot_a.py" This reverts commit a03b5ee. * Revert "Also remove TestModelMinorCompatability" This reverts commit 11fdd5c. * Revert "remove TestModelMajorCompatability as compatibility was added" This reverts commit 40dd807. * revert allowing 0.0 model * convert from model 1.3 to 2.0 * fix .gitignore
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…ath expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…ath expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…ath expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Next plan: add v1.2 compatibility)