Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc: "structures" should be a list #1091

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

HuangJiameng
Copy link
Collaborator

The type of parameter "structures" in relaxation.json of dpgen autotest should be a list. Fix the wrong type in Autotest Overview.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.55%. Comparing base (a9d324b) to head (e5e338b).
Report is 193 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1091   +/-   ##
=======================================
  Coverage   39.55%   39.55%           
=======================================
  Files          99       99           
  Lines       17981    17981           
=======================================
  Hits         7112     7112           
  Misses      10869    10869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnguseZhang
Copy link
Collaborator

Do we also need to optimize the error log if users provide wrong types of inputs? Probably use dargs? @HuangJiameng

@njzjz
Copy link
Member

njzjz commented Dec 30, 2022

Do we also need to optimize the error log if users provide wrong types of inputs?

You can open a new issue to track it.

@HuangJiameng
Copy link
Collaborator Author

Do we also need to optimize the error log if users provide wrong types of inputs? Probably use dargs? @HuangJiameng

The check on input argument dict hasn't been applied to autotest yet. An issue is welcomed.

@wanghan-iapcm wanghan-iapcm merged commit ed26994 into deepmodeling:devel Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants