Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples in INCAR_md and POTCAR #570

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Fix examples in INCAR_md and POTCAR #570

merged 4 commits into from
Oct 11, 2021

Conversation

AnguseZhang
Copy link
Collaborator

  1. I add comments in relevant places to tell users that they should provide valid POTCARS themselves to fix Why dpgen/examples/run/dp1.x-lammps-vasp/CH4/POT_C is empty?  #560
  2. I found there is problem in my last commit on CH4's VASP-md INCAR. So I reverted this file to the versio in https://github.com/deepmodeling/dpgen/blob/3bc32690dbcbb5aa2f9a16f2ba89a05e48caedb4/examples/init/INCAR_methane.md .

@amcadmus amcadmus merged commit eacf7bc into deepmodeling:devel Oct 11, 2021
Cloudac7 pushed a commit to Cloudac7/dpgen that referenced this pull request Dec 1, 2021
@AnguseZhang @Cloudac7
Fix examples in INCAR_md and POTCAR (deepmodeling#570)
646f1e4 
* Change mv to cp when downloading softlinks.

* Add explanations relevant to POTCAR's examples.

* Fix CH4's vasp-md INCAR example.
@AnguseZhang AnguseZhang mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcadmus amcadmus amcadmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnguseZhang @amcadmus