Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dpgen run machine parameters #710

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 24, 2022

No description provided.

@njzjz njzjz requested a review from AnguseZhang April 24, 2022 05:20
@njzjz
Copy link
Member Author

njzjz commented Apr 24, 2022

What's wrong with the UT?

@AnguseZhang
Copy link
Collaborator

AnguseZhang commented Apr 24, 2022

What's wrong with the UT?

dpdata 0.2.6 has not supported ABACUS for older version than 2.2. So UT in DP-GEN also fails. @Liu-RX Could you please fix UT in DP-GEN?

@Liu-RX
Copy link
Collaborator

Liu-RX commented Apr 24, 2022

What's wrong with the UT?

dpdata 0.2.6 has not supported for older version than 2.2. So UT in DP-GEN also fails. @Liu-RX Could you please fix UT in DP-GEN?

I have fixed it in #705. But I haven't fulfill your review requirements. I will do it as soon as possible.

@AnguseZhang
Copy link
Collaborator

What's wrong with the UT?

dpdata 0.2.6 has not supported for older version than 2.2. So UT in DP-GEN also fails. @Liu-RX Could you please fix UT in DP-GEN?

I have fixed it in #705. But I haven't fulfill your review requirements. I will do it as soon as possible.

Ok. Thanks !

@njzjz
Copy link
Member Author

njzjz commented Apr 24, 2022

@AnguseZhang could you enable the PR preview in read the docs?
image

@AnguseZhang
Copy link
Collaborator

@AnguseZhang could you enable the PR preview in read the docs? image

Yes @njzjz I've done. Does it work?

@njzjz njzjz closed this Apr 24, 2022
@njzjz njzjz reopened this Apr 24, 2022
@njzjz
Copy link
Member Author

njzjz commented Apr 24, 2022

@AnguseZhang could you enable the PR preview in read the docs? image

Yes @njzjz I've done. Does it work?

It should work: https://deepmodeling--710.org.readthedocs.build/projects/dpgen/en/710/run-mdata.html

@AnguseZhang AnguseZhang reopened this Apr 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #710 (3d3891e) into devel (37df129) will decrease coverage by 0.14%.
The diff coverage is 9.52%.

@@            Coverage Diff             @@
##            devel     #710      +/-   ##
==========================================
- Coverage   34.05%   33.91%   -0.15%     
==========================================
  Files          92       93       +1     
  Lines       16377    16562     +185     
==========================================
+ Hits         5578     5617      +39     
- Misses      10799    10945     +146     
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 0.00% <0.00%> (ø)
dpgen/dispatcher/Dispatcher.py 31.98% <20.00%> (-0.51%) ⬇️
dpgen/generator/lib/abacus_scf.py 80.46% <0.00%> (-3.08%) ⬇️
dpgen/data/gen.py 48.47% <0.00%> (-2.38%) ⬇️
dpgen/generator/run.py 62.28% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37df129...3d3891e. Read the comment docs.

@AnguseZhang AnguseZhang merged commit 33baad0 into deepmodeling:devel Apr 24, 2022
@njzjz njzjz added the documentation Improvements or additions to documentation label Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants