strict check simplify jdata #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the simplify jdata is confirmed to be completed (if not, please remind me), we could enable the strict check.
njzjz
commented
Sep 15, 2022
dpgen/simplify/simplify.py
Outdated
| @@ -413,6 +414,9 @@ def run_iter(param_file, machine_file): | |||
| with open(machine_file, 'r') as fp: | |||
| mdata = json.load(fp) | |||
|
|
|||
| jdata_arginfo = simplify_jdata_arginfo() | |||
| jdata = normalize(jdata_arginfo, jdata) | |||
|
|
|||
| if jdata.get('pretty_print', False): | |||
There was a problem hiding this comment.
... What is pretty_print used for?
Codecov Report
@@ Coverage Diff @@
## devel #951 +/- ##
==========================================
- Coverage 38.16% 38.15% -0.01%
==========================================
Files 99 99
Lines 17885 17888 +3
==========================================
Hits 6825 6825
- Misses 11060 11063 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
no one uses it
|
I modified the arginfo of |
HuangJiameng
approved these changes
Sep 28, 2022
tuoping
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the simplify jdata is confirmed to be completed (if not, please remind me), we could enable the strict check.