Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Kubernetes package with wait logic #98

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Jun 5, 2024

Description

This change adds a new Kubernetes package meant for related logic. It also adds functions which allows users to easily wait for resources to be properly reconciled.

Related Issue

Relates to #zarf-dev/zarf#2580
Relates to #defenseunicorns/lula#229

@phillebaba
Copy link
Member Author

I am a bit unsure if having a single struct for just waiting is a good idea, but we can always deprecate it in the future and replace it with something else if we see the need. It is better to enable others to easily get the waiting logic first.

AustinAbro321
AustinAbro321 previously approved these changes Jun 6, 2024
.github/workflows/check-kubernetes.yaml Outdated Show resolved Hide resolved
@lucasrod16 lucasrod16 changed the title Add Kubernetes package with wait logic feat: add Kubernetes package with wait logic Jun 6, 2024
Copy link
Contributor

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with coming back to add a usage example for this code at later time because we may have to make some changes when we integrate this logic into Zarf

kubernetes/go.mod Outdated Show resolved Hide resolved
kubernetes/kubernetes.go Show resolved Hide resolved
kubernetes/wait.go Outdated Show resolved Hide resolved
@lucasrod16 lucasrod16 merged commit 4803ac2 into defenseunicorns:main Jun 7, 2024
12 checks passed
@phillebaba phillebaba deleted the feature/kubernetes branch June 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants