Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt uds-common renovate config #389

Closed
mjnagel opened this issue May 3, 2024 · 0 comments · Fixed by #391
Closed

Adopt uds-common renovate config #389

mjnagel opened this issue May 3, 2024 · 0 comments · Fixed by #391
Assignees

Comments

@mjnagel
Copy link
Contributor

mjnagel commented May 3, 2024

Describe what should be investigated or refactored

We currently maintain a length and very specific renovate config for uds-core. UDS-Common maintains a great genericized config that we could adopt and help to extend if it doesn't catch all of our current dependencies. We will likely want to maintain our packagerules and maybe some other one-offs (neuvector image comes to mind), but the rest of these should be able to leverage the common config.

This should absolutely be validated to ensure we don't lose track of any dependencies.

Additional context

Worth noting that we are currently missing a check for one place zarf init is used in CI, which is covered by the common config - 1b5f604

@UnicornChance UnicornChance linked a pull request May 8, 2024 that will close this issue
5 tasks
@UnicornChance UnicornChance self-assigned this May 9, 2024
UnicornChance added a commit that referenced this issue May 9, 2024
## Description
Utilize the uds-common renovate config.
* Now includes major and minor upgrades instead of only major
* No longer uses `latest` bucket, instead uses the major minor buckets
* Removes lots of false positive matches on the keyword docker
* Properly gets versions from task files ( except for the pepr
controller in task/setup.yaml )

Four repo specific regex matchers are needed for the pepr controller and
for managing neuvector values files.

Also includes an update to Keycloak package for catching two versions
with upstream docker image.

## Related Issue

Fixes #389 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this issue Jul 11, 2024
## Description
Utilize the uds-common renovate config.
* Now includes major and minor upgrades instead of only major
* No longer uses `latest` bucket, instead uses the major minor buckets
* Removes lots of false positive matches on the keyword docker
* Properly gets versions from task files ( except for the pepr
controller in task/setup.yaml )

Four repo specific regex matchers are needed for the pepr controller and
for managing neuvector values files.

Also includes an update to Keycloak package for catching two versions
with upstream docker image.

## Related Issue

Fixes #389 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants