fix: pepr operator derived netpol name collisions #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
approved these changes
Jun 13, 2024
mjnagel
pushed a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop* --- ## [0.22.2](v0.22.1...v0.22.2) (2024-06-13) ### Bug Fixes * check if exemption exists before cleanup ([#468](#468)) ([735288b](735288b)) * pepr operator derived netpol name collisions ([#480](#480)) ([de60e25](de60e25)) * typo in comment ([#462](#462)) ([582b1f4](582b1f4)) ### Miscellaneous * **deps:** update checkout to v4.1.7 ([#478](#478)) ([e91a0a3](e91a0a3)) * **deps:** update githubactions to v4.1.3 ([#471](#471)) ([2a9f44d](2a9f44d)) * **deps:** update uds to v0.11.1 ([#472](#472)) ([12fd798](12fd798)) * **deps:** update uds to v0.11.2 ([#479](#479)) ([f967f9a](f967f9a)) * **deps:** update velero to v1.30.2 ([#476](#476)) ([89bbda9](89bbda9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes network policy naming bug that caused name collisions for operator derived network policies. This causes network policies being created for VirtualServices using the same selector and gateway but different ports to be dropped. Multiple legitimate policies would override each other and only the last would survive.
There are still gaps in the fundamentals of naming and validation that I came across on different iterations on solutions for this. I will be creating a follow on issue for a deeper dive into that though. This is a small improvement that fixes a specific issue.
...
Related Issue
Fixes #466
Type of change
Checklist before merging