chore: update loki #734
Merged
chore: update loki #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Sep 9, 2024
Comment on lines
6
to
15
| data: | ||
| # v13schemadate defaults to two days in the future | ||
| {{- $configmap := (lookup "v1" "ConfigMap" "loki" "loki-schema") }} | ||
| {{- if .Values.v13schemadate }} | ||
| v13schemadate: {{ .Values.v13schemadate }} | ||
| {{- else if $configmap }} | ||
| v13schemadate: {{ $configmap.data.v13schemadate }} | ||
| {{- else }} | ||
| v13schemadate: {{ (now | dateModify "+48h" | date "2006-01-02") | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
(realize that I suggested some of this, but a few thoughts)
- Not really sure we need
v13schemadatevalue - if someone wants to override they could directly modify the loki schema values, although they'd have to override the full block - If this is a fresh install we can actually put the date in the past - we don't have to, but it's one less thing for new installs to have to include. Probably could do with
.Release.IsInstall+ dateModify minus 48h? - Controlling this schema config with helm templating makes me a bit scared, but it may be the right place? Can see both sides to this...
mjnagel
approved these changes
Sep 9, 2024
mjnagel
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging