Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch authservice checksum updates #735

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

UnicornChance
Copy link
Contributor

Description

Currently we apply a new checksum to the authservice deployment for each chain addition, update, or deletion. This results in multiple applies, sometimes for a single package.

Batch per packages so that a package with multiple authservice clients only results in one checksum. Moved the checksum functionality to the end of the authservice reconciliation

Related Issue

Fixes #561

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@UnicornChance UnicornChance self-assigned this Sep 9, 2024
@UnicornChance UnicornChance requested a review from a team as a code owner September 9, 2024 14:54
@UnicornChance UnicornChance linked an issue Sep 9, 2024 that may be closed by this pull request
@rjferguson21
Copy link
Contributor

@UnicornChance Did you take a stab at addressing at batching authservice updates across multiple packages?

IMO I don't think this is worth doing unless we address that scenario. I don't think we have anyone who currently using more than one sso client per Package.

I would try to debounce whatever function is actually checksuming the deployment and that would probably work.

@UnicornChance UnicornChance marked this pull request as draft September 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch authservice checksum updates
2 participants