Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile View: If Contact has long bio, then shared chats are hidden #4092

Closed
Simon-Laux opened this issue Aug 24, 2024 · 0 comments · Fixed by #4093 or #4074
Closed

Profile View: If Contact has long bio, then shared chats are hidden #4092

Simon-Laux opened this issue Aug 24, 2024 · 0 comments · Fixed by #4093 or #4074
Assignees
Labels
bug Something isn't working

Comments

@Simon-Laux
Copy link
Member

Simon-Laux commented Aug 24, 2024

Because shared chats just take the remaining space and if the bio/signature/status of a contact is long, then there is no space left.

Solution would be to set a minimum height:

/* how many items should be shown atleast if they exist */
const minHeightMin = 1
const minHeightMax = 5
const chatlistitemHeight = /* the code to extract that from the css variable, look into chatlist for that */

const minHeight = chatlistitemHeight * Math.min(Math.max(minHeightMin, itemCount), minHeightMax)

// then in react code:
<div className='mutual-chats' style={{ flexGrow: 1, minHeight }}>
@Simon-Laux Simon-Laux added the bug Something isn't working label Aug 24, 2024
@Simon-Laux Simon-Laux self-assigned this Aug 24, 2024
Simon-Laux added a commit that referenced this issue Aug 29, 2024
* set min height for shared chats in profile view
fixes #4092

* more clear varname

* refactor styles a tiny bit to make status text scroll if there is little space

* remove workaround from #4068, can't reproduce the bug of it anymore

* fix that you can not click header button in dialog when they are on top of the navbar
also see #4018

* add changelog entries
Simon-Laux added a commit that referenced this issue Aug 29, 2024
* set min height for shared chats in profile view
fixes #4092

* more clear varname

* refactor styles a tiny bit to make status text scroll if there is little space

* remove workaround from #4068, can't reproduce the bug of it anymore

* fix that you can not click header button in dialog when they are on top of the navbar
also see #4018

* add changelog entries
@Simon-Laux Simon-Laux mentioned this issue Aug 29, 2024
3 tasks
Simon-Laux added a commit that referenced this issue Sep 8, 2024
* set min height for shared chats in profile view
fixes #4092

* more clear varname

* refactor styles a tiny bit to make status text scroll if there is little space

* remove workaround from #4068, can't reproduce the bug of it anymore

* fix that you can not click header button in dialog when they are on top of the navbar
also see #4018

* add changelog entries
Simon-Laux added a commit that referenced this issue Sep 9, 2024
* set min height for shared chats in profile view
fixes #4092

* more clear varname

* refactor styles a tiny bit to make status text scroll if there is little space

* remove workaround from #4068, can't reproduce the bug of it anymore

* fix that you can not click header button in dialog when they are on top of the navbar
also see #4018

* add changelog entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant