fix: QR scanning not showing errors on failure #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
fix-qr-scanner-not-showing-error
branch
from
5264ed0
to
9efea46
Compare
Simon-Laux
approved these changes
Jul 21, 2024
WofWca
commented
Jul 21, 2024
`useTranslationFunction` hook cannot be used when we create the component instance like this. This, however, removes an extra new line, but it's not bad. To reproduce, send this (invalid) link in a chat and click it: https://i.delta.chat/#dummy&a=example%40testrun.org&n=test&i=test&s=test
WofWca
force-pushed
the
fix-qr-scanner-not-showing-error
branch
from
9efea46
to
134c259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useTranslationFunctionhook cannot be used when we create the component instance like this.This, however, removes an extra new line, but it's not bad.
To reproduce, send this (invalid) link in a chat and click it: https://i.delta.chat/#dummy&a=example%40testrun.org&n=test&i=test&s=test