-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactionsDialog: drop email, make rows clickable #4071
Conversation
maxphilippov
commented
Aug 8, 2024
•
edited
Loading
edited
- don't show email in reactions dialog unless user has no display name
- clicking on a row in reactions dialog opens a user profile
- resolved remove email address from reaction details & make details tappable #4066
46da94e
to
1ad6470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "click to open contact" is nice, but I'm not sure if removing the address is good.
1ad6470
to
0fa5566
Compare
tuning down email adresses is an ongoing process and needed for chatmail, this PR and reactions is only one small step in that effort. for reasoning, see eg. https://delta.chat/en/2024-05-31-instant-onboarding#are-we-de-emphasizing-e-mail-addresses-in-the-user-interface - the approach was recently confirmed several times by user get stuck using email adresses. it is better to push to other ways to get in contact, as using invite links or qr codes. but if user see an email address before, they will try with that and fail :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
if is better when tapping the "Me" self-reaction just does nothing; opening "Saved messages" is not helpful and is unexpected. on Android, we also just do nothing
-
when doing an action from the contact, eg. tap a shared chat or tap "send-message", it is weird that the "reaction" dialog stays opened (cmp corresponding discussion about that in the linked issue)
otherwise, functionalty-wise, this lgtm. thanks a lot for pushing that foward
- don't show email in reactions dialog unless user has no display name - clicking on a row in reactions dialog opens a user profile
0fa5566
to
1dc80f9
Compare