Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactionsDialog: drop email, make rows clickable #4071

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

maxphilippov
Copy link
Collaborator

@maxphilippov maxphilippov commented Aug 8, 2024

@maxphilippov maxphilippov force-pushed the maxph/4066-remove-email-from-reaction branch from 46da94e to 1ad6470 Compare August 8, 2024 07:53
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "click to open contact" is nice, but I'm not sure if removing the address is good.

@maxphilippov maxphilippov force-pushed the maxph/4066-remove-email-from-reaction branch from 1ad6470 to 0fa5566 Compare August 8, 2024 08:32
@r10s
Copy link
Member

r10s commented Aug 8, 2024

but I'm not sure if removing the address is good

tuning down email adresses is an ongoing process and needed for chatmail, this PR and reactions is only one small step in that effort.

for reasoning, see eg. https://delta.chat/en/2024-05-31-instant-onboarding#are-we-de-emphasizing-e-mail-addresses-in-the-user-interface - the approach was recently confirmed several times by user get stuck using email adresses. it is better to push to other ways to get in contact, as using invite links or qr codes. but if user see an email address before, they will try with that and fail :)

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • if is better when tapping the "Me" self-reaction just does nothing; opening "Saved messages" is not helpful and is unexpected. on Android, we also just do nothing

  • when doing an action from the contact, eg. tap a shared chat or tap "send-message", it is weird that the "reaction" dialog stays opened (cmp corresponding discussion about that in the linked issue)

otherwise, functionalty-wise, this lgtm. thanks a lot for pushing that foward

@Simon-Laux Simon-Laux requested a review from nicodh August 8, 2024 22:14
- don't show email in reactions dialog unless user has no display name
- clicking on a row in reactions dialog opens a user profile
@maxphilippov maxphilippov force-pushed the maxph/4066-remove-email-from-reaction branch from 0fa5566 to 1dc80f9 Compare September 1, 2024 03:36
@maxphilippov maxphilippov merged commit 617c821 into main Sep 5, 2024
7 checks passed
@maxphilippov maxphilippov deleted the maxph/4066-remove-email-from-reaction branch September 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

remove email address from reaction details & make details tappable
4 participants