Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packaging: windows 64bit and 32bit releases now have different filenames #4131

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix: packaging: windows 64bit and 32bit releases now have different filenames #4131

merged 2 commits into from
Sep 13, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Sep 13, 2024 •
edited
Loading

closes #3973

r10s
r10s approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot say much to that, but lgtm so far :)

packages/target-electron/build/gen-electron-builder-config.js Show resolved Hide resolved
@Simon-Laux Simon-Laux merged commit 33edc07 into main Sep 13, 2024
6 of 7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3973-fix-windows-packaging-different-names-for-32-and-64bit-windows branch September 13, 2024 19:30
@Simon-Laux Simon-Laux mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More recent versions than 1.44.1 package app-32.7z instead of app-64.7z
2 participants
@Simon-Laux @r10s