fix: some shortcuts not working on different langs #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-shortcuts-on-different-layouts
branch
from
fe43c36
to
3379996
Compare
Simon-Laux
approved these changes
Sep 18, 2024
Different keyboard layouts (e.g. Russian). `event.key` gives you the printed character and not the key code. If the language doesn't use latin letters, you'll never get Ctrl + N or Ctrl + K to work. This behavior aligns with e.g. Telegram, and browsers (Ctrl + W). There is a side-effect, however. The shortcuts cheat-sheet shows which buttons you're currently pressing, and now it diverges from actual behavior. E.g. if you actually press the key with the code "Comma", it won't show you this for the Russian language where the key to print a comma is different. See `KeyboardShortcutHint.tsx`. I think this can be fixed later, especially that it's already buggy: it won't show you that you're pressing "N" because you'd actually need to press "Shift+N", otherwise you get "n".
...wherever applicable. About `key.toLowerCase()`: it appears that it was unnecessary.
WofWca
force-pushed
the
wofwca/fix-shortcuts-on-different-layouts
branch
from
3379996
to
fc07333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different keyboard layouts (e.g. Russian).
event.keygives you the printed character and not the key code.If the language doesn't use latin letters, you'll never get
Ctrl + N or Ctrl + K to work.
This behavior aligns with e.g. Telegram, and browsers (Ctrl + W).
There is a side-effect, however. The shortcuts cheat-sheet
shows which buttons you're currently pressing, and now it diverges
from actual behavior.
E.g. if you actually press the key with the code "Comma",
it won't show you this for the Russian language where the key
to print a comma is different.
See
KeyboardShortcutHint.tsx.I think this can be fixed later, especially that it's already buggy:
it won't show you that you're pressing "N" because
you'd actually need to press "Shift+N", otherwise you get "n".