Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat overriden sender name as content above attachment #4142

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Treat overriden sender name as content above attachment #4142

merged 1 commit into from
Sep 23, 2024

Conversation

maxphilippov
Copy link
Collaborator

Simon-Laux
Simon-Laux approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Simon-Laux Simon-Laux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didn't test. I think this can be tested with adb's community experiment or using the dev console to send image messages with overriden sender name.

@maxphilippov
Copy link
Collaborator Author

code looks good, didn't test. I think this can be tested with adb's community experiment or using the dev console to send image messages with overriden sender name.

Did test that, contacted adb before, cause I didn't get what was the problem at first.

@maxphilippov maxphilippov merged commit 95eb474 into main Sep 23, 2024
7 of 8 checks passed
@maxphilippov maxphilippov deleted the maxph/3914-overriden-sender-name-layout-fix branch September 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Laux Simon-Laux Simon-Laux approved these changes

@nicodh nicodh Awaiting requested review from nicodh

@WofWca WofWca Awaiting requested review from WofWca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layout bug in image message from self with overridden sender name
2 participants
@maxphilippov @Simon-Laux