Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize URLs as IRIs in commandline output #10810

Closed
marrus-sh opened this issue Jun 1, 2021 · 0 comments · Fixed by #23200
Closed

Serialize URLs as IRIs in commandline output #10810

marrus-sh opened this issue Jun 1, 2021 · 0 comments · Fixed by #23200
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@marrus-sh
Copy link

When running tests (deno test) or throwing errors (deno run), URLs are rendered according to the URI syntax, with non‐ASCII characters percent‐encoded. For example, one might see:

running 8 tests from file:///Users/myUser/Repositories/MyRepo/E%C2%B7C%C2%B7M%C2%B7A%C2%B7262.test.js

when running a test located at /Users/myUser/Repositories/MyRepo/E·C·M·A·262.test.js.

This is horribly unreadable and serves very little utility to users. (Imagine programming in a language other than English!) It would be better if the URL was rendered according to the IRI syntax, with only the characters not allowed in IRIs percent‐encoded.

Version Info: deno 1.10.2 (release, x86_64-apple-darwin)
@kitsonk kitsonk added the suggestion suggestions for new features (yet to be agreed) label Jun 1, 2021
@Hajime-san Hajime-san mentioned this issue Feb 26, 2024
Merged
@Hajime-san Hajime-san mentioned this issue Apr 3, 2024
Merged
bartlomieju pushed a commit that referenced this issue May 28, 2024
@Hajime-san
fix(cli/test): decoding percent-encoding(non-ASCII) file path correct…
9aa593c 
…ly (#23200)

# Summary

This PR resolves about the issue.
fixes #10810

And the formerly context is in the PR. 
#22582

Here is an expected behaviour example with this change.

- 🦕.test.ts
```ts
import { assertEquals } from "https://deno.land/std@0.215.0/assert/mod.ts";

Deno.test("example test", () => {
  assertEquals("🍋", "🦕");
});
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli/test): decoding percent-encoding(non-ASCII) file path correctly Hajime-san/deno
2 participants
@kitsonk @marrus-sh