feat(repl): add --eval flag for evaluating code when the repl starts #11590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 5, 2021
dsherret
commented
Aug 5, 2021
| .long("eval") | ||
| .help("Evaluates the provided code when the REPL starts.") | ||
| .takes_value(true) | ||
| .value_name("code"), |
There was a problem hiding this comment.
I've noticed some parts of the code require an equals sign. Should this? deno repl --eval="console.log(5);"? I'm not sure when to use the equals sign and when not to.
There was a problem hiding this comment.
I think it shouldn't require equals. The equals sign is required in some places to disambiguate. I don't remember the exact situation off hand, but we should attempt to remove the equals-sign-requirement if the ambiguity has evaporated.
dsherret
commented
Aug 5, 2021
| if let EvaluationOutput::Error(error_text) = output { | ||
| println!("error in --eval flag. {}", error_text); | ||
| } | ||
| } |
There was a problem hiding this comment.
It was super easy to implement this thanks to the recent refactorings in this code 😀
dsherret
changed the title
dsherret
force-pushed
the
repl-eval-flag
branch
from
a36a260
to
710983e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3173
At the moment, this only adds support for an
--eval <code>flag to provide some code to execute on startup.For example:
deno repl --eval 'import * as hash from "https://deno.land/std@0.77.0/hash#stdhash"'We will consider adding support for URL and file paths in the future, but for now this is a first step.