Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/webgpu): fix GPUUncapturedErrorEvent parent type #24369

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(ext/webgpu): fix GPUUncapturedErrorEvent parent type #24369

merged 2 commits into from
Jul 10, 2024

Conversation

turansky
Copy link
Contributor

MDN

Expected

Parent - Event

Actual

Parent - EventTarget

@turansky
WebGPU. Fix GPUUncapturedErrorEvent parent type
2792cc2 
Signed-off-by: Victor Turansky <victor.turansky@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

littledivy
littledivy approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy changed the title WebGPU. Fix GPUUncapturedErrorEvent parent type fix(ext/webgpu): fix GPUUncapturedErrorEvent parent type Jul 9, 2024
@littledivy littledivy merged commit 92d567d into denoland:main Jul 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turansky @CLAassistant @littledivy