Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsr): support publishing jsr packages in npm workspaces #24507

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(jsr): support publishing jsr packages in npm workspaces #24507

merged 1 commit into from
Jul 10, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 10, 2024 •
edited
Loading

Supports publishing an npm workspace with a directory structure similar to the following:

  • workspace
    • package.json
    • package-a
      • package.json
      • jsr.json
    • package-b
      • package.json
      • jsr.json

deno_config PR: denoland/deno_config#77

Closes #23638

@dsherret dsherret added this to the 1.45 milestone Jul 10, 2024
bartlomieju
bartlomieju approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 4d2d764 into denoland:main Jul 10, 2024
17 checks passed
@dsherret dsherret deleted the feat_npm_workspace_jsr_packages branch July 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.

Map npm workspace packages to JSR specifiers on publish if npm package in workspace is a jsr package?
3 participants
@dsherret @marvinhagemeister @bartlomieju