Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set v8_enable_handle_zapping to false #1188

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Explicitly set v8_enable_handle_zapping to false #1188

merged 2 commits into from
Feb 11, 2023

Conversation

littledivy
Copy link
Member

No description provided.

ry
ry approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that this is for perf

LGTM

@aapoalas
Copy link
Contributor

What is "handle zapping" actually?

@littledivy
Copy link
Member Author

littledivy commented Feb 11, 2023 •
edited
Loading

@aapoalas IIUC zapping is rewriting a memory region with garbage (read it somewhere in a v8 issue).

-DENABLE_HANDLE_ZAPPING enables this bit of code: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/handles/handles.cc;l=182;bpv=1;bpt=1?q=ENABLE_HANDLE_ZAPPING&ss=chromium%2Fchromium%2Fsrc

Also relevant Node.js PR: nodejs/node#23801

@littledivy littledivy merged commit 6043e7d into denoland:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @aapoalas @ry