Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fs): improve documentation #4788

Merged
merged 13 commits into from
Jun 7, 2024
Merged

docs(fs): improve documentation #4788

merged 13 commits into from
Jun 7, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 21, 2024

Hopefully takes documentation from great to excellent.

@github-actions github-actions bot added the fs label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (5a6e99c) to head (8d9d321).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4788   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         487      487           
  Lines       41561    41564    +3     
  Branches     5365     5365           
=======================================
+ Hits        38224    38227    +3     
  Misses       3279     3279           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (628814e) to head (d2c56f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4788   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         487      487           
  Lines       38766    38773    +7     
  Branches     5428     5428           
=======================================
+ Hits        35682    35689    +7     
  Misses       3027     3027           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 5, 2024 22:21
@iuioiua iuioiua requested a review from kt3k as a code owner June 5, 2024 22:21
@iuioiua iuioiua mentioned this pull request Jun 5, 2024
38 tasks
fs/empty_dir.ts Outdated Show resolved Hide resolved
fs/expand_glob.ts Outdated Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments. Other part looks good to me.

@iuioiua iuioiua requested a review from kt3k June 6, 2024 20:19
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@iuioiua iuioiua merged commit 35c240e into main Jun 7, 2024
12 checks passed
@iuioiua iuioiua deleted the fs-docs-2 branch June 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants