Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(ini): remove internal Formatting type #4818

Merged
merged 1 commit into from
May 23, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 21, 2024

Seems like we should just use FormattingOptions here?

@dsherret dsherret requested a review from kt3k as a code owner May 21, 2024 19:53
@github-actions github-actions bot added the ini label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (0ef767f) to head (783f10c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4818      +/-   ##
==========================================
- Coverage   91.94%   91.94%   -0.01%     
==========================================
  Files         486      486              
  Lines       41327    41318       -9     
  Branches     5321     5321              
==========================================
- Hits        37998    37989       -9     
  Misses       3272     3272              
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. As this is a minor breaking change, the next version of this package should be a minor release, right?

@kt3k
Copy link
Member

kt3k commented May 22, 2024

As this is a minor breaking change, the next version of this package should be a minor release, right?

Sounds correct. Ok, let's tag this as BREAKING

@kt3k kt3k changed the title refactor(ini): remove internal Formatting type BREAKING(ini): remove internal Formatting type May 22, 2024
@dsherret dsherret merged commit acc38b8 into denoland:main May 23, 2024
14 checks passed
@dsherret dsherret deleted the refactor_remove_formatting_type branch May 23, 2024 16:54
@iuioiua iuioiua mentioned this pull request Jun 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants